Fix regex character class parsing#38
Closed
davejcameron wants to merge 1 commit into
Closed
Conversation
Owner
|
Landed on The branch was let cls = false;
const pattern = next(c =>
c === BSLASH ? 2 :
c === LBRACK ? (cls = true, 1) :
c === RBRACK ? (cls = false, 1) :
c && (cls || c !== SLASH)
);Added |
dy
added a commit
that referenced
this pull request
May 18, 2026
`/` inside a `[...]` character class is literal, not a terminator. Track a `cls` flag while scanning the pattern so `/[^/]+$/` and `/[\]/]/` parse correctly. Closes #38. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Regex literals can contain
/inside character classes, but the parser currently treats the first/as the end of the regex body even when it appears inside[...].Fix
Track when the regex scanner is inside a character class, so
/only terminates the literal outside of character classes. Escapes continue to consume the escaped character as part of the pattern.Add focused regex coverage for character classes containing
/.Validation
/inside character classes